Fix: travis release and update stages called on all builds#16
Merged
Fix: travis release and update stages called on all builds#16
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #16 +/- ##
========================================
Coverage 66.85% 66.85%
========================================
Files 2 2
Lines 175 175
========================================
Hits 117 117
Misses 58 58
Continue to review full report at Codecov.
|
tunniclm
approved these changes
Jan 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current use of build stages is intended to only be run on pushes to master; however, they are being run on all builds leading to unnecessary tagging and overuse of the github api.
It turns out that the boolean condition was invalidly formatted leading travis to ignore it completely. By removing the
platform = Linuxconditional, everything works as expected.