Skip to content

Query Param Integration#14

Merged
sandmman merged 15 commits intodevelopfrom
issue.queryParams
Jan 30, 2018
Merged

Query Param Integration#14
sandmman merged 15 commits intodevelopfrom
issue.queryParams

Conversation

@sandmman
Copy link
Copy Markdown
Contributor

@sandmman sandmman commented Jan 10, 2018 •
edited
Loading

With the integration of Kitura Evolution Proposal #0003 for Codable query param integration, we need to incorporate the updated apis into KituraKit.

This introduces the following apis:

func get<O: Codable, Q: Codable>(_ route: String, query: Q, respondWith: @escaping CodableArrayResultClosure<O>)
func delete<Q: Codable>(_ route: String, query: Q, respondWith: @escaping ResultClosure)

Additionally, this PR includes mild refactoring of the SwiftyRequest logic to decrease code duplication. Any feedback is appreciated

  • Note: This PR is dependent on the tagging of the updated version of Kitura and KituraContracts, so the package.swift will need to be updated when those are approved.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 10, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@571e2da). Click here to learn what that means.
The diff coverage is 75.6%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #14   +/-   ##
==========================================
  Coverage           ?   71.96%           
==========================================
  Files              ?        2           
  Lines              ?      132           
  Branches           ?        0           
==========================================
  Hits               ?       95           
  Misses             ?       37           
  Partials           ?        0
Flag Coverage Δ
#KituraKit 71.96% <75.6%> (?)
Impacted Files Coverage Δ
Sources/KituraKit/Client.swift 76.03% <75.6%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 571e2da...8502720. Read the comment docs.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 30, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ sandmman
❌ Travis CI User

Travis CI User seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sandmman sandmman merged commit e3427a5 into develop Jan 30, 2018
@sandmman sandmman deleted the issue.queryParams branch January 30, 2018 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sandmman @codecov-io @CLAassistant