UUID extended to conform to Identifier#47
Merged
djones6 merged 4 commits intoKitura:masterfrom Sep 24, 2019
mcritz:uuid-identifier
Merged
UUID extended to conform to Identifier#47djones6 merged 4 commits intoKitura:masterfrom mcritz:uuid-identifier
djones6 merged 4 commits intoKitura:masterfrom
mcritz:uuid-identifier
Conversation
|
|
|
@mcritz Thanks for doing this. Hopefully it is merged in soon. I'll be using it in one of my projects. |
djones6
reviewed
Sep 23, 2019
Contributor
djones6
left a comment
There was a problem hiding this comment.
This looks fine to me. One small nit-pick:
djones6
approved these changes
Sep 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #46