Conversation
ianpartridge
reviewed
Jul 3, 2018
Contributor
ianpartridge
left a comment
There was a problem hiding this comment.
This looks fine, but I'm wondering... Why are the operators var instead of let? For example in struct GreaterThan we have:
private var `operator`: Operator = .greaterThanIf this was:
private let `operator`: Operator = .greaterThanwould the TypeDecoder be able to decode?
Contributor
Author
|
AMAZING! I did not see that - works perfectly |
Contributor
|
Excellent, and I think we can fix this in a patch release? |
Contributor
Author
|
yeah - I think a patch will be fine even if we are modifying external "api" |
nhardman
approved these changes
Jul 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating swagger with Query Parameters, Neil realised that the TypeDecoder could not decode some special types like
GreaterThan. This is due to the fact that these types contain a Operator Enum field.When decoding, the decoder has to return a value in a specific type. In this example, the value returned is a
String:In the case of the TypeDecoder, it returns dummy values to keep the compiler happy. When decoding an Enum is returns a dummy value. This causes an error because that dummy value is not of the same type as that Enum. Furthermore, we could not construct an enum from
rawValuebecause none of the cases match the empty string.To solve this issue, we implement a custom decoder for these special types where we decide to not decode the
OperatorEnum field since it already has a default value. We will only decode the value field associated with those types.