Conversation
ianpartridge
approved these changes
Apr 4, 2019
This was referenced Apr 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates
.swift-versionto Swift 5, switches to the new Swift 5 Docker images for the CI, and resolves a bunch of compilation warnings in Kitura-net and the tests.The warnings mostly relate to changes to
Data.withUnsafeBytes, for which I haven't been able to track down the relevant Swift Evolution proposal, but there's discussion of here: https://forums.swift.org/t/unsaferawbufferpointer-in-swift-5/22165Motivation and Context
How Has This Been Tested?
Checklist: