Merged
Conversation
ianpartridge
requested changes
Apr 16, 2018
| ("testTextMediumMessage", testTextMediumMessage), | ||
| ("testTextShortMessage", testTextShortMessage), | ||
| ("testUserDefinedCloseMessage", testUserDefinedCloseMessage) | ||
| ("testNullCharacter", testNullCharacter), |
Contributor
There was a problem hiding this comment.
This is failing on Linux.
Contributor
There was a problem hiding this comment.
You could comment this line out for now, so we can merge this PR.
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
=========================================
+ Coverage 92.27% 92.4% +0.12%
=========================================
Files 9 9
Lines 492 500 +8
=========================================
+ Hits 454 462 +8
Misses 38 38
Continue to review full report at Codecov.
|
ianpartridge
approved these changes
Apr 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of passing Autobahn test suite, added feature to take user defined close message and check for valid UTF8 encoding.
Added two tests to check the functionality.
Added testNullCharacter to alltests
Renamed testUserDefinedCloseMessage to testUserDefinedCloseCode to distinguish tests