Merged
Conversation
ianpartridge
approved these changes
Apr 16, 2018
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
- Coverage 92.33% 92.27% -0.07%
==========================================
Files 9 9
Lines 496 492 -4
==========================================
- Hits 458 454 -4
Misses 38 38
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the system for converting data to string.
Previously data had a null terminator added on the end and was converted to a pointer which was then used to read as a string up to the null terminator. If the user sent a null terminator in their string then their message would only be read up to that point.
Now the Data is converted straight to a utf8 string and sent on.
Test added to check this behavior.