Merged
Conversation
ianpartridge
approved these changes
Mar 12, 2018
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 90.64% 90.68% +0.03%
==========================================
Files 9 9
Lines 481 483 +2
==========================================
+ Hits 436 438 +2
Misses 45 45
Continue to review full report at Codecov.
|
| return | ||
| } | ||
| guard frame.finalFrame else { | ||
| connectionClosed(reason: .protocolError, description: "Control frames cannot be fragmented") |
Contributor
There was a problem hiding this comment.
Maybe it would be a bit better to say "Control frames must not be fragmented", to match the language of the spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By the websockets protocol control frames such as ping, close and pong cannot be fragmented.
This means we should close if we receive a control frame which has a continuation.
Since pong and close will close already we have only changed ping.
This now passes autobahn test 5.1 and a test to check this has been added.