Merged
Conversation
ianpartridge
approved these changes
Mar 12, 2018
Contributor
ianpartridge
left a comment
There was a problem hiding this comment.
LGTM. As discussed, this is an API breaking change, but seems unavoidable.
I think we should keep chipping away at the test failures, with the goal of releasing 2.0.0 alongside Swift 4.1 with 100% pass rate.
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
+ Coverage 90.64% 91.26% +0.62%
==========================================
Files 9 9
Lines 481 481
==========================================
+ Hits 436 439 +3
+ Misses 45 42 -3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug caused when i user sent a large code reason code.
This was caused by the server using Int16 instead of UInt16.
A test for user defined large input has been added and now passed.