fix: Use PKCS7 padding for cookie cryptor#62
Merged
Andrew-Lees11 merged 2 commits intomasterfrom Mar 11, 2019
Merged
Conversation
Contributor
Author
|
@Lukasa |
|
Yup, that looks a lot better. |
ianpartridge
approved these changes
Mar 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is In response to issue #61.
In cookie cryptor, we were ecrypting the session Id using aes with our own implementation of padding where we would add 0x00 until it was the correct block size. Then when decrypting we would only take the first 36 bytes. This will only give us our original plaintext back if the input was 36 bytes long (The size of a UUID).
This was working since we consistently used the shortened data however this is fragile and if an input of less than 16 bytes was used then it would crash on trying to decrypt.
This PR changes our encode and decode to use BlueCryptor PKCS7 padding so that we can encrypt and decrypt and length and the original plaintext will be returned.