fix: Remove Codable sessions for Swift 4.0#59
Merged
Andrew-Lees11 merged 6 commits intomasterfrom Jan 29, 2019
Merged
Conversation
djones6
reviewed
Jan 29, 2019
|
|
||
|
|
||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Could we get rid of some of this trailing whitespace?
djones6
approved these changes
Jan 29, 2019
Contributor
djones6
left a comment
There was a problem hiding this comment.
Looks good, bar the errant whitespace
| @testable import KituraSessionTests | ||
|
|
||
|
|
||
| #if swift(>=4.1) |
Collaborator
There was a problem hiding this comment.
This might be better (uncompiled):
var testcases = [testCase(TestSession.allTests), testCase(TestTypeSafeSession.allTests]
#if swift(>=4.1)
testcases.append(TestCodableSession.allTests)
#endif
XCTMain(testcases)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the Codable Session feature for Swift 4.0. This is because the Swift 4.0 compiler doesn't go down the Any subscript path when a complex object is not codable. This can cause existing code to break which caused a test failure in credentials.