Use SwaggerUI 3.25.0: better compatibility with OpenAPI 3.0.x#29
Use SwaggerUI 3.25.0: better compatibility with OpenAPI 3.0.x#29djones6 merged 2 commits intoKitura:masterfrom
Conversation
swaggerui/index.html
Outdated
| window.onload = function() { | ||
| // Build a system | ||
| const ui = SwaggerUIBundle({ | ||
| url: "/doc", |
There was a problem hiding this comment.
Because there is a swagger serving endpoint URL hard-coded into this file, we instead templated it (see https://github.com/IBM-Swift/Kitura-OpenAPI/blob/master/swaggerui/template.html), and Kitura-OpenAPI will write an index.html file with the appropriate link: https://github.com/IBM-Swift/Kitura-OpenAPI/blob/f8cffe163cc75de00cb187c6df06afcb5ed26508/Sources/KituraOpenAPI/KituraOpenAPI.swift#L141.
If the new UI requires updates to the index.html, make them to template.html instead (keeping the placeholder)
|
@mbarnach Other than the comment above about the templating of the index.html, this looks good to me. |
|
I've removed the index.html file. No changes were needed I think in template.html. |
|
This is now tagged in Kitura-OpenAPI |
When trying new features of OpenAPI, I've realized some JSON could be valid and supported by the editor at https://editor.swagger.io/ but not by Kitura-OpenAPI UI. This is due to some issues/bug in the version 3.18 and/or higher.
I've update some files in SwaggerUI (not sure if this all needed or not) and it fixes the issue.
The new page keeps the Kitura logo instead of the SwaggerUI logo (as before).