Remove Stencil from Kitura-OpenAPI#19
Merged
DunnCoding merged 2 commits intoKitura:masterfrom Jan 30, 2019
DunnCoding:issue.16
Merged
Remove Stencil from Kitura-OpenAPI#19DunnCoding merged 2 commits intoKitura:masterfrom DunnCoding:issue.16
DunnCoding merged 2 commits intoKitura:masterfrom
DunnCoding:issue.16
Conversation
djones6
suggested changes
Jan 30, 2019
Contributor
djones6
left a comment
There was a problem hiding this comment.
Looks good, barring a few nit-picky comments
| public class KituraOpenAPI { | ||
| public static var defaultConfig = KituraOpenAPIConfig(apiPath: "/openapi", swaggerUIPath: "/openapi/ui") | ||
|
|
||
| sourcesDirectory += "/swaggerui/index.html" | ||
| let fileURL = URL(fileURLWithPath: sourcesDirectory) | ||
| do { | ||
| try "".write(to: fileURL, atomically: true, encoding: .utf8) |
Contributor
There was a problem hiding this comment.
Should we not delete the destination file instead?
| if let response = response { | ||
| if let wrappedhtml = try? response.readString() { | ||
| if let html = wrappedhtml { | ||
| print(html) |
Contributor
There was a problem hiding this comment.
I suspect you didn't mean to leave this here...
djones6
approved these changes
Jan 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to remove Kitura Stencil as a dependency from Kitura OpenAPI.
I've used the FileManager to gain access to the files, reading the contents and using
replacingOccurrences(of:with:)to update the contents before writing.I've also created another file,
template.html, which will is the source we read from and then write toindex.htmlwhich is the page we serve.A
tearDown()function was also added to the tests. This is to ensure after each run of the tests we delete the index.html.Tested on both macOS and Linux.