Allow POST success status codes besides 201 (CREATED)#1218
Closed
c1ira wants to merge 1 commit intoKitura:masterfrom
c1ira:master
Closed
Allow POST success status codes besides 201 (CREATED)#1218c1ira wants to merge 1 commit intoKitura:masterfrom c1ira:master
c1ira wants to merge 1 commit intoKitura:masterfrom
c1ira:master
Conversation
…f one explicitly specifies any other success response, such as 200 (OK), Kitura treats it like an error. This change along with a dependent change in Kitura-net allow Kitura to send any success response for a POST.
|
|
2 tasks
3 tasks
Collaborator
|
Note that this would need reworking due to conflict with recent changes:
I believe it would involve applying this logic to the |
Contributor
Author
|
@djones6 Unless you object, I'd like to close this PR and revisit when the dust has settled on #1222, #1214 and Kitura/Kitura-net#246. |
Contributor
Author
|
Will create new PR after dust has settled on #1222, #1214 and Kitura/Kitura-net#246. |
Collaborator
|
@c1ira the dust has settled 🙂 Would you be willing to pick this up again? |
Contributor
Author
|
@ianpartridge Yes, thanks for poking me. |
2 tasks
Contributor
Author
|
@ianpartridge Replacement PR is: #1254 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow POST success status codes besides 201 (CREATED)
Description
This change allows Kitura to send any success response for a POST. This is dependent on a change in Kitura-net: Kitura/Kitura-net#240 . This will fail to build unless/until the Kitura-net PR dependency is resolved.
Motivation and Context
When Kitura receives a POST, its success response is 201 (CREATED). If one explicitly specifies any other success response, such as 200 (OK), Kitura treats it like an error.
How Has This Been Tested?
Ran
swift test.Have been using this modification at Capital One for several months.
Checklist: