Fix broken URLSession on Linux platform#60
Merged
ianpartridge merged 2 commits intoKitura:masterfrom Jun 25, 2019
segabor:master
Merged
Fix broken URLSession on Linux platform#60ianpartridge merged 2 commits intoKitura:masterfrom segabor:master
ianpartridge merged 2 commits intoKitura:masterfrom
segabor:master
Conversation
|
|
Contributor
|
Thank you for the PR! Please can you sign the CLA ^^^^^^ ? The format we've been going for with this is: #if swift(>=4.1)
#if canImport(FoundationNetworking)
import FoundationNetworking
#endif
#endif |
Contributor
Author
|
Ok, so this change requires Swift 5.1. |
Contributor
|
Yes this is a Swift 5.1 change. We need to keep backwards compatibility with older versions of Swift in this package though. Thanks. |
Contributor
Author
Thanks, I'm going to update the PR. |
Contributor
Author
|
Contributor
|
You should be able to do it by clicking on the link above.
|
ianpartridge
approved these changes
Jun 25, 2019
Contributor
Contributor
Author
|
Awesome! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Configurationmodule no longer builds on Linux sinceURLSessiontype is extracted fromFoundationframework to a separate oneFoundationNetworkingUPDATE Just realized this fix is required for Swift version <= 5.1. Current official release 5.0.1 does not support
#canImportdirective and there's noFoundationNetworkingsubmodule yet.Motivation and Context
I use Configuration in one of my pet project and recently noticed that build fails due to above issue.
How Has This Been Tested?
Ran automated tests.
Checklist: