Conversation
ianpartridge
approved these changes
Jan 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensures that environment variables are only parsed with the JSON deserializer.
Motivation and Context
The current code attempts to parse each environment variable using the JSON deserializer and then the PLIST deserializer, before finally returning the value as-is. This works, but is a bit unnecessary since it seems highly unlikely that someone would store structured data in PLIST format in an environment variable.
Worse, if the value contains a semicolon, the PLIST deserializer writes a messy error message directly to stdout, which we cannot suppress. This PR prevents this by specifying only the JSON deserializer when processing env vars.
Resolves #55
How Has This Been Tested?
The existing tests pass.
Checklist: