Load credentials of the databases-for-postgresql format#60
Merged
ianpartridge merged 3 commits intoKitura:masterfrom Jun 21, 2019
Merged
Load credentials of the databases-for-postgresql format#60ianpartridge merged 3 commits intoKitura:masterfrom
databases-for-postgresql format#60ianpartridge merged 3 commits intoKitura:masterfrom
Conversation
… `databases-for-postgresql` format of Cloud Foundry.
|
|
Contributor
|
Thanks! We'll review asap. |
Contributor
ianpartridge
left a comment
There was a problem hiding this comment.
Thanks for the PR! It looks good to me.
Please add you add API doc comments to the new function? Please make it clear that the new function is for "Databases for PostgreSQL" and also update the comment on the getPostgreSQLCredentials() function above to say that the old function is for "Compose for PostgreSQL".
That way users can be guided to the right function depending on the cloud service they are using.
ianpartridge
approved these changes
Jun 21, 2019
Contributor
ianpartridge
left a comment
There was a problem hiding this comment.
Thanks! Will merge once CI passes.
I guess you'd like a tagged release?
Member
Author
|
A new version would be great indeed! Thanks. |
Contributor
|
Released |
Member
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add loading of CloudEnviroment credentials for PostgreSQL through the
databases-for-postgresqlformat of Cloud Foundry.The function
getPostgreSQLCredentialsis not working in such case.A new test has been added.