Skip to content

Support Swift 5#51

Merged
ianpartridge merged 4 commits intomasterfrom
swift5
Apr 15, 2019
Merged

Support Swift 5#51
ianpartridge merged 4 commits intomasterfrom
swift5

Conversation

@djones6
Copy link
Contributor

@djones6 djones6 commented Apr 4, 2019 •
edited
Loading

Update to Swift 5, and use official Docker images for CI.

WIP: Tests fail to compile on MacOS with Swift 5:

/Users/travis/build/IBM-Swift/CircuitBreaker/Tests/CircuitBreakerTests/CircuitBreakerTests.swift:129:32: error: 'defaultRunLoopMode' has been renamed to 'RunLoop.Mode.default'
    RunLoop.current.run(mode: .defaultRunLoopMode, before: Date(timeIntervalSinceNow: 0.001))
                               ^~~~~~~~~~~~~~~~~~
                               RunLoop.Mode.default
Foundation.RunLoop.Mode:4:23: note: 'defaultRunLoopMode' was obsoleted in Swift 4.2
    public static let defaultRunLoopMode: RunLoop.Mode
                      ^

Also, there are lots of intermittent failures, not the same set captured in #49 but I suspect the same underlying problem. This really needs investigation.

@djones6 djones6 requested a review from ianpartridge April 4, 2019 16:02
@ianpartridge ianpartridge mentioned this pull request Apr 4, 2019
Closed
@djones6 djones6 changed the title Support Swift 5 [WIP] Support Swift 5 Apr 4, 2019
@ianpartridge ianpartridge self-requested a review April 15, 2019 10:44
@ianpartridge ianpartridge changed the title [WIP] Support Swift 5 Support Swift 5 Apr 15, 2019
@ianpartridge ianpartridge merged commit 63db267 into master Apr 15, 2019
@ianpartridge ianpartridge deleted the swift5 branch April 15, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianpartridge ianpartridge ianpartridge approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@djones6 @ianpartridge @Andrew-Lees11