feat: add app font size setting#10028
Open
jwchmodx wants to merge 1 commit intoKittyCAD:mainfrom
Open
Conversation
Add an 'appFontSize' setting under app settings that allows users to scale the app's base font size via a multiplier (0.5x to 2.0x). This is distinct from browser zoom — it only affects text size, helping users with vision needs without scaling the entire UI. The setting is applied by updating document.documentElement.style.fontSize as a percentage of the default (e.g. 1.25 → 125%). Closes KittyCAD#8077
|
Someone is attempting to deploy a commit to the Zoo Team on Vercel. A member of the Team first needs to authorize it. |
| description: | ||
| 'A multiplier for the base font size of the app (e.g. 1.25 = 25% larger)', | ||
| validate: (v) => | ||
| typeof v === 'number' && v >= 0.5 && v <= 3.0, |
Contributor
There was a problem hiding this comment.
Validation allows values up to 3.0x but the PR description states support is for 0.5x to 2.0x, and the options list only goes up to 2.0x. This inconsistency could cause issues:
- Users could set values between 2.0-3.0 via direct config editing that won't appear in the command palette
- Values above 2.0x may not be tested and could cause UI layout issues
Fix by aligning validation with the stated range:
validate: (v) =>
typeof v === 'number' && v >= 0.5 && v <= 2.0,
Suggested change
| typeof v === 'number' && v >= 0.5 && v <= 3.0, | |
| typeof v === 'number' && v >= 0.5 && v <= 2.0, |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8077. Added
app.appFontSizesetting that allows users to adjust the application font size via the command palette. Supports scales from 0.5x to 2.0x.