Skip to content

Update to parallel_gripper_controller#324

Merged
aalmrad merged 1 commit intoKinovarobotics:jazzyfrom
sea-bass:update-controller-type
Dec 9, 2025
Merged

Update to parallel_gripper_controller#324
aalmrad merged 1 commit intoKinovarobotics:jazzyfrom
sea-bass:update-controller-type

Conversation

@sea-bass
Copy link
Copy Markdown
Contributor

@sea-bass sea-bass commented Nov 30, 2025

Equivalent to PickNikRobotics/ros2_robotiq_gripper#103 on the gripper side.

This only works for Jazzy and newer btw.

Closes #294

MarqRazz
MarqRazz previously approved these changes Dec 4, 2025
@MarqRazz
Copy link
Copy Markdown
Collaborator

MarqRazz commented Dec 5, 2025

This only works for Jazzy and newer btw.

Sounds like this actually needs more work before we can merge it. There are CI checks against humble and I assume the MoveIt tutorials in Humble also use this so we need to add branches for specific distros to this repo. @smoya23 are you maintaining this repo for Kinova? Can you make these changes?

@MarqRazz MarqRazz dismissed their stale review December 5, 2025 16:47

Repo needs to support multiple distros.

@sea-bass
Copy link
Copy Markdown
Contributor Author

sea-bass commented Dec 6, 2025

There does already seem to be a humble branch here: https://github.com/Kinovarobotics/ros2_kortex/tree/humble -- last updated 3 weeks ago at the time of writing

Maybe it's a combination of updating the CI rules here to do the humble jobs only on that branch, plus updating the moveit tutorials to use the appropriate ros2_kortex branch?

@aalmrad
Copy link
Copy Markdown
Collaborator

aalmrad commented Dec 8, 2025

I have justed created a jazzy branch based on the main branch with separate CI workflow: https://github.com/Kinovarobotics/ros2_kortex/tree/jazzy @sea-bass, can you please open a pull request on the jazzy branch?

@sea-bass sea-bass changed the base branch from main to jazzy December 8, 2025 23:19
@sea-bass sea-bass closed this Dec 8, 2025
@sea-bass sea-bass reopened this Dec 8, 2025
@sea-bass
Copy link
Copy Markdown
Contributor Author

sea-bass commented Dec 9, 2025

I have justed created a jazzy branch based on the main branch with separate CI workflow: https://github.com/Kinovarobotics/ros2_kortex/tree/jazzy @sea-bass, can you please open a pull request on the jazzy branch?

Done! Just changed the base branch in this PR.

The ROS 2 lint checks are failing because of outdated keys it seems: https://discourse.openrobotics.org/t/ros-signing-key-migration-guide/43937 -- or actually, it may be solved by #299?

The Rolling checks failing because of deprecations solved in #309

@aalmrad
Copy link
Copy Markdown
Collaborator

aalmrad commented Dec 9, 2025

@sea-bass ROS2 lint should be good now

@aalmrad aalmrad closed this Dec 9, 2025
@aalmrad aalmrad reopened this Dec 9, 2025
@aalmrad aalmrad merged commit 414c0bd into Kinovarobotics:jazzy Dec 9, 2025
11 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gripper_controllers is deprecated in Kilted and later

3 participants