fix: revert enabled number ordering on feetokenmetadata proto construct#326
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe change renumbers the Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@proto/kiichain/feeabstraction/v1beta1/params.proto`:
- Line 43: The proto change reverted the bool field "enabled" from tag 5 to tag
6 (proto/kiichain/feeabstraction/v1beta1/params.proto), which will break
unmarshalling of any payloads encoded with tag 5; first confirm whether tag 5
was ever deployed to any network/testnet/pre-release, and if it was, restore
backward compatibility by either keeping a deprecated duplicate field for tag 5
or updating the generated unmarshal logic to accept both tag numbers for Enabled
(i.e., handle tag 5 as an alias for Enabled in the unmarshal function for the
Params message); ensure the chosen fix is applied to the proto and regenerated
code and include a migration/state-repair plan if tag 5 is confirmed deployed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: af123395-69b5-4cdd-8536-07f779f6613b
⛔ Files ignored due to path filters (1)
x/feeabstraction/types/params.pb.gois excluded by!**/*.pb.go
📒 Files selected for processing (1)
proto/kiichain/feeabstraction/v1beta1/params.proto
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Description
Revert enabled number ordering on feetokenmetadata proto construct so a migration isn't required to handle the field change
Type of change
PR Checklist:
Make sure each step was done:
make lint-fix