release: v7.1.0#283
Conversation
WalkthroughThis pull request upgrades the codebase from v7.0.0 to v7.1.0. The v7_0 upgrade package files (constants.go and upgrade.go) are deleted entirely, removing the v7.0.0 upgrade handler and associated EVM initialization logic. The app/app.go file is updated to reference v7_1.Upgrade instead of v7_0.Upgrade in the Upgrades registry. The CHANGELOG.md top-level heading is changed from UNRELEASED to v7.1.0 - 2026-03-10, establishing a specific release version marker. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
app/app.go (1)
71-81:⚠️ Potential issue | 🔴 CriticalKeep
v7_0registered or replay from older heights can break.Line 81 drops
v7_0.UpgradefromUpgrades, andsetupUpgradeStoreLoaders()/setupUpgradeHandlers()only register entries from that slice (app/app.go:488-518). After this change, a node replaying from genesis or restoring from a pre-v7.0.0 snapshot no longer has a handler/store loader for the historical"v7.0.0"plan, so it can halt at that upgrade boundary. If dropping support for replay before v7.0.0 is intentional, that needs to be an explicit compatibility break, not incidental cleanup.Suggested fix
import ( "fmt" "io" "io/fs" "net/http" "os" "path/filepath" @@ kiiante "github.com/kiichain/kiichain/v7/ante" "github.com/kiichain/kiichain/v7/app/keepers" "github.com/kiichain/kiichain/v7/app/upgrades" + v7_0 "github.com/kiichain/kiichain/v7/app/upgrades/v7_0" v7_1 "github.com/kiichain/kiichain/v7/app/upgrades/v7_1" "github.com/kiichain/kiichain/v7/client/docs" ) @@ // Upgrades is a list of all the upgrades that are available for the application. Upgrades = []upgrades.Upgrade{ + v7_0.Upgrade, v7_1.Upgrade, } )🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@app/app.go` around lines 71 - 81, The Upgrades slice no longer includes v7_0.Upgrade which causes setupUpgradeStoreLoaders and setupUpgradeHandlers to miss the "v7.0.0" plan during replay; re-add v7_0.Upgrade to the Upgrades slice (the variable Upgrades in app.go) so setupUpgradeStoreLoaders() and setupUpgradeHandlers() will register the v7.0.0 store loader and handler, or if you intend to drop pre-v7.0.0 replay support make that compatibility break explicit in the code/comments and ensure setupUpgradeStoreLoaders()/setupUpgradeHandlers() reflect the intentional omission.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@app/app.go`:
- Around line 71-81: The Upgrades slice no longer includes v7_0.Upgrade which
causes setupUpgradeStoreLoaders and setupUpgradeHandlers to miss the "v7.0.0"
plan during replay; re-add v7_0.Upgrade to the Upgrades slice (the variable
Upgrades in app.go) so setupUpgradeStoreLoaders() and setupUpgradeHandlers()
will register the v7.0.0 store loader and handler, or if you intend to drop
pre-v7.0.0 replay support make that compatibility break explicit in the
code/comments and ensure setupUpgradeStoreLoaders()/setupUpgradeHandlers()
reflect the intentional omission.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e85b6e77-23d9-46e3-ab45-94e3409ea055
📒 Files selected for processing (4)
CHANGELOG.mdapp/app.goapp/upgrades/v7_0/constants.goapp/upgrades/v7_0/upgrade.go
💤 Files with no reviewable changes (2)
- app/upgrades/v7_0/upgrade.go
- app/upgrades/v7_0/constants.go
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Description
Swaps upgrade to v7.1.0
Type of change