Remove nogas deadcode#195
Conversation
WalkthroughThis pull request removes dead code related to no gas consumption. The noConsumptionGasMeter type and its public constructor NewNoConsumptionGasMeter are deleted from the ante package, along with all associated method implementations. The CHANGELOG.md is updated to document this removal. Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR removes dead code by deleting the unused ante/no_gas.go file, which contained a custom gas meter implementation that doesn't consume any gas. The removal has been documented in the CHANGELOG.
Key Changes:
- Deleted the entire
ante/no_gas.gofile containing thenoConsumptionGasMeterimplementation - Updated CHANGELOG.md to document the removal under the "Removed" section
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ante/no_gas.go | Removed unused gas meter implementation that never consumed gas |
| CHANGELOG.md | Added entry documenting the removal of dead code under the UNRELEASED section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
CHANGELOG.md (1)
7-7: Changelog entry could be more specific about what was removed.The entry "Removed dead code related to no gas consumption" is accurate but somewhat vague. Consider being more explicit about what was removed (e.g., "Removed unused noConsumptionGasMeter type from ante package").
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.mdante/no_gas.go
💤 Files with no reviewable changes (1)
- ante/no_gas.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze
🔇 Additional comments (1)
CHANGELOG.md (1)
5-7: Dead code removal is complete with no broken dependencies.Confirmed that all references to
noConsumptionGasMeter,NewNoConsumptionGasMeter, and theante/no_gas.gofile have been removed from the codebase. No remaining code depends on the removed functionality, and test files contain no references to the removed types.
|
Related to #193 |
Description
Remove the no gas dead code
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
No changes in test needed