Fix memory semantics validation rules according to the spec#4008
Merged
dnovillo merged 1 commit intoKhronosGroup:mainfrom Jul 31, 2025
Merged
Fix memory semantics validation rules according to the spec#4008dnovillo merged 1 commit intoKhronosGroup:mainfrom
dnovillo merged 1 commit intoKhronosGroup:mainfrom
Conversation
This commit updates memory semantics validation rules to match Vulkan specification update KhronosGroup/Vulkan-Docs#2528 and spirv-tools update KhronosGroup/SPIRV-Tools#6096 Signed-off-by: Natalia Gavrilenko <natalia.gavrilenko@huawei.com>
|
|
jeffbolznv
approved these changes
Jul 31, 2025
Contributor
jeffbolznv
left a comment
There was a problem hiding this comment.
I didn't look through the test changes, but the ParseHelper.cpp changes LGTM.
Contributor
|
I also took a look at the ParseHelper changes and spot checked some tests. LGTM |
dnovillo
approved these changes
Jul 31, 2025
Collaborator
dnovillo
left a comment
There was a problem hiding this comment.
LGTM. Will merge once all the workflows finish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates memory semantics validation rules to match Vulkan specification update
KhronosGroup/Vulkan-Docs#2528 and spirv-tools update
KhronosGroup/SPIRV-Tools#6096