Fix 8-bit storage nearly always using the UniformAndStorageBuffer8BitAccess capability.#1542
Merged
johnkslang merged 1 commit intoKhronosGroup:masterfrom Oct 26, 2018
sheredom:fix_8bit_storagebuffer
Merged
Fix 8-bit storage nearly always using the UniformAndStorageBuffer8BitAccess capability.#1542johnkslang merged 1 commit intoKhronosGroup:masterfrom sheredom:fix_8bit_storagebuffer
johnkslang merged 1 commit intoKhronosGroup:masterfrom
sheredom:fix_8bit_storagebuffer
Conversation
|
|
Contributor
|
The bots seem to have a legitimate failure: It looks like the results from To update those tests (assuming the changes are valid). |
UniformAndStorageBuffer8BitAccess capability. When using the 8-bit storage extension it basically always used the `UniformAndStorageBuffer8BitAccess` capability, even in cases where it wasn't required. For instance if we are targeting Vulkan 1.1 (SPIR-V 1.3 or higher), and we are only using 8-bit types in an SSBO, we only need the `StorageBuffer8BitAccess` capability. I fixed this by enabling storage buffer use in Vulkan 1.1 / SPIR-V 1.3 or higher, and then changing the logic to match. I also added some tests that will output different capabilities when run on Vulkan 1.0 and 1.1, thus they are added twice to the test list (one for each version). Fixes #1539
Author
|
So the appveyor thing looks bogus to me - lot of errors in gtest?! Dunno if I inadvertently caused these or not... 😢 |
Contributor
|
No, you did not cause the gtest errors. I'm temporarily accepting PRs that fail for only that reason. |
Author
|
Ok ok - I think that is the only error then! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the 8-bit storage extension it basically always used the
UniformAndStorageBuffer8BitAccesscapability, even in cases where itwasn't required. For instance if we are targeting Vulkan 1.1 (SPIR-V 1.3
or higher), and we are only using 8-bit types in an SSBO, we only need
the
StorageBuffer8BitAccesscapability.I fixed this by enabling storage buffer use in Vulkan 1.1 / SPIR-V 1.3
or higher, and then changing the logic to match.
I also added some tests that will output different capabilities when run
on Vulkan 1.0 and 1.1, thus they are added twice to the test list (one
for each version).
Fixes #1539