-
Notifications
You must be signed in to change notification settings - Fork 956
Please bump GLSLANG_PATCH_LEVEL after major API changes #1538
Description
In git master you removed the NV_EXTENSIONS macro checks from the TBuiltInResources, which every user is forced to copy/paste from the glslang examples. Since having done this, you didn't bump the GLSLANG_PATCH_LEVEL, so you broke the compilation of every single dependent without a way to conditionally compile. So as it stands, users can either write code that works only on master but not on the latest release, or write code that works only on the latest release but not master.
Can you please update the GLSLANG_PATCH_LEVEL, ideally every time you break the core API?
(As an aside, I don't understand why glslang doesn't just provide its own TBuiltInResources in the headers, so that users can just use it instead of copy/pasting it from the examples. About 50% of my glslang code is just this struct definition. You already define it in StandAlone/ResourceLimits.h but this header does not get installed as part of the public API - which is odd because the CMakeLists references a library glslang-default-resource-limits that doesn't seem to actually get built. What's up with this?)