scripts: Add SPIRV-Tools option to stats#2145
scripts: Add SPIRV-Tools option to stats#2145mark-lunarg merged 1 commit intoKhronosGroup:masterfrom
Conversation
| print (" [ -c ]") | ||
| print (" [ -todo ]") | ||
| print (" [ -vuid <vuid_name> ]") | ||
| print (" [ -unassigned ]") |
mark-lunarg
left a comment
There was a problem hiding this comment.
This LGTM, and I'd like to do a bit more testing when the WIP comes off.
a5cf304 to
4986644
Compare
|
@mark-lunarg The SPIRV-Tools changes are merged into ToT and this script is ready to be used.
|
|
@sfricke-samsung, yep, will get to it after 152 lands -- it had an unusual amount of VUID churn and so is taking a bit longer than usual. And after seeing your note that all the SPIR-V VUIDs were in one file, I agree that having the path here is the best thing to do. |
|
@mark-lunarg Sounds good, there is really no rush for me for this change, I am going to focusing on closing the about 66% coverage cap (in terms of the new VUID labels added) currently in Built-Ins in SPIR-V Tools and just wanted a way to track it... this PR is more of my courtesy of not just dumping a new process on you without volunteering to add the code... so quite honestly don't feel afraid to just refactor this PR as much as you want to fit your flow |
|
This seemed to work fine in my testing. Note that known-good is still set to behind your changes to spirv-tools, but it seems harmless enough to push. Thanks Spencer! |
Closes #2141
Marked as WIP until KhronosGroup/SPIRV-Tools#3756 is merged
This allows you to go