Skip to content

scripts: Add SPIRV-Tools option to stats#2145

Merged
mark-lunarg merged 1 commit intoKhronosGroup:masterfrom
sfricke-samsung:sfricke-samsung-spirvtool
Sep 10, 2020
Merged

scripts: Add SPIRV-Tools option to stats#2145
mark-lunarg merged 1 commit intoKhronosGroup:masterfrom
sfricke-samsung:sfricke-samsung-spirvtool

Conversation

@sfricke-samsung
Copy link
Copy Markdown
Contributor

Closes #2141
Marked as WIP until KhronosGroup/SPIRV-Tools#3756 is merged

This allows you to go

python vk_validation_stats.py validusage.json -spirvtools SPIRV-Tools/

@mark-lunarg mark-lunarg self-assigned this Aug 31, 2020
print (" [ -c ]")
print (" [ -todo ]")
print (" [ -vuid <vuid_name> ]")
print (" [ -unassigned ]")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Contributor

@mark-lunarg mark-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, and I'd like to do a bit more testing when the WIP comes off.

@sfricke-samsung sfricke-samsung force-pushed the sfricke-samsung-spirvtool branch from a5cf304 to 4986644 Compare September 3, 2020 04:05
@sfricke-samsung sfricke-samsung changed the title [WIP] scripts: Add SPIRV-Tools option to stats scripts: Add SPIRV-Tools option to stats Sep 3, 2020
@sfricke-samsung
Copy link
Copy Markdown
Contributor Author

@mark-lunarg The SPIRV-Tools changes are merged into ToT and this script is ready to be used.

  • You will need the 1.2.152 headers as those are where the new SPIR-V built-in VUIDs are even added (will show as 0 VUIDs with 151 headers otherwise)
  • We discussed the idea of having the file paths in SPIR-V Tools, but decided to simply the flow with just listing them here

@mark-lunarg
Copy link
Copy Markdown
Contributor

@sfricke-samsung, yep, will get to it after 152 lands -- it had an unusual amount of VUID churn and so is taking a bit longer than usual. And after seeing your note that all the SPIR-V VUIDs were in one file, I agree that having the path here is the best thing to do.

@sfricke-samsung
Copy link
Copy Markdown
Contributor Author

@mark-lunarg Sounds good, there is really no rush for me for this change, I am going to focusing on closing the about 66% coverage cap (in terms of the new VUID labels added) currently in Built-Ins in SPIR-V Tools and just wanted a way to track it... this PR is more of my courtesy of not just dumping a new process on you without volunteering to add the code... so quite honestly don't feel afraid to just refactor this PR as much as you want to fit your flow

@mark-lunarg
Copy link
Copy Markdown
Contributor

This seemed to work fine in my testing. Note that known-good is still set to behind your changes to spirv-tools, but it seems harmless enough to push. Thanks Spencer!

@mark-lunarg mark-lunarg merged commit c374f7c into KhronosGroup:master Sep 10, 2020
@sfricke-samsung sfricke-samsung deleted the sfricke-samsung-spirvtool branch September 11, 2020 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to go about scanning SPIR-V Tools for VUIDs

2 participants