vulkan.pc cross-compile fix#756
Conversation
|
Author jwinarske not on autobuild list. Waiting for curator authorization before starting CI build. |
|
|
|
CI Vulkan-Loader build queued with queue ID 7450. |
|
CI Vulkan-Loader build # 840 running. |
|
CI Vulkan-Loader build # 840 passed. |
dcbaker
left a comment
There was a problem hiding this comment.
This is correct, this allows pkgconfig --define-variable=prefix=something to work correctly, the current .pc file is not actually a properly formated pkg-config file.
- pkg-config variable ${prefix} is required for adjusting sysroot
Signed-off-by: Joel Winarske <joel.winarske@gmail.com>
b6f5f8e to
f51b873
Compare
|
Author jwinarske not on autobuild list. Waiting for curator authorization before starting CI build. |
|
Needs to go into 1.2.182.0 as well. |
|
CI Vulkan-Loader build queued with queue ID 7480. |
Why does it need to go into this version specifically? The SDK branch is generally not updated once branched (save for fixes that are made why the SDK is being tested and are cherry-picked over). |
|
CI Vulkan-Loader build # 841 running. |
|
Yocto Honister is based on 1.2.182. Looking back this issue shows up starting with 1.2.162. So a patch for Yocto might be more portable. |
|
CI Vulkan-Loader build # 841 passed. |
|
Ah yes, this 'bug' has been in the codebase for a while so a downstream patch would be best. |
charles-lunarg
left a comment
There was a problem hiding this comment.
Changes look good. Thank for you fixing this and verifying it, since pc config stuff is not something I have a terribly large amount of experience with. I will merge assuming it passes CI.
Signed-off-by: Joel Winarske joel.winarske@gmail.com