Skip to content

CMake: Fix libdir in pkg-config file, dehardcode includedir#491

Merged
lenny-lunarg merged 1 commit intoKhronosGroup:masterfrom
akien-mga:pkgconfig-absolute-libdir
Oct 20, 2020
Merged

CMake: Fix libdir in pkg-config file, dehardcode includedir#491
lenny-lunarg merged 1 commit intoKhronosGroup:masterfrom
akien-mga:pkgconfig-absolute-libdir

Conversation

@akien-mga
Copy link
Copy Markdown
Contributor

Fixes #489.
Supersedes #214.

Those CMAKE_INSTALL_FULL_* defines depend on GNUInstallDirs, which is included in CMakeLists.txt.

@akien-mga
Copy link
Copy Markdown
Contributor Author

Output after this patch on Mageia (Linux, RPM-based):

$ cat /usr/lib64/pkgconfig/vulkan.pc 
prefix=/usr
exec_prefix=/usr
libdir=/usr/lib64
includedir=/usr/include

Name: Vulkan-Loader
Description: Vulkan Loader
Version: 1.2.154
Libs: -L${libdir} -lvulkan
Libs.private:  -lstdc++ -lm -lgcc_s -lgcc -lc -lgcc_s -lgcc
Cflags: -I${includedir}

Copy link
Copy Markdown
Contributor

@lenny-lunarg lenny-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR (and sorry for the delay).

@lenny-lunarg lenny-lunarg merged commit 5d51a8a into KhronosGroup:master Oct 20, 2020
@akien-mga akien-mga deleted the pkgconfig-absolute-libdir branch December 30, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong libdir in pkg-config .pc files if CMAKE_INSTALL_LIBDIR is absolute

2 participants