Fix vulkan.pc Libs.private for static builds#1054
Merged
charles-lunarg merged 1 commit intoKhronosGroup:masterfrom Nov 4, 2022
Merged
Fix vulkan.pc Libs.private for static builds#1054charles-lunarg merged 1 commit intoKhronosGroup:masterfrom
charles-lunarg merged 1 commit intoKhronosGroup:masterfrom
Conversation
|
CI Vulkan-Loader build queued with queue ID 25782. |
|
CI Vulkan-Loader build # 1597 running. |
|
CI Vulkan-Loader build # 1597 passed. |
0248fe9 to
1f86d2d
Compare
|
CI Vulkan-Loader build queued with queue ID 27416. |
|
CI Vulkan-Loader build # 1608 running. |
|
CI Vulkan-Loader build # 1608 failed. |
The Libs.private field shouldn't be present for shared library builds, so now the field wont be present in that case. For static library builds it should be present, but the fields should be deduplicated as well. Additionally, this adds a github actions run for testing the static build of the loader on MacOS. This requires making the test framework capable of using a statically built loader, which mainly took making VulkanFunctions capable of assigning the statically defined functions instead of loading them with dlsym. The static build option required changes to the unix_shim.cpp to not cause infinite loops.
1f86d2d to
bf9d6d8
Compare
|
CI Vulkan-Loader build queued with queue ID 27424. |
|
CI Vulkan-Loader build # 1609 running. |
|
CI Vulkan-Loader build # 1609 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Libs.private field shouldn't be present for shared library builds, so now the field wont be present in that case. For static library builds it should be present, but the fields should be deduplicated as well.
Additionally, this adds a github actions run for testing the static build of the loader on MacOS.
Fixes #490