Skip to content

[Android] wrong signatures for terminator_CreateAndroidSurfaceKHR() and vkCreateAndroidSurfaceKHR() #96

@elix22

Description

@elix22

Hi
There is a mismatch in the function signatures causing compilation failure while compiling for Android ,at least for me :).

The type definition of the API can be found in the link below.
https://github.com/KhronosGroup/Vulkan-Headers/blob/master/include/vulkan/vulkan_android.h

typedef VkResult (VKAPI_PTR *PFN_vkCreateAndroidSurfaceKHR)(VkInstance instance, const VkAndroidSurfaceCreateInfoKHR* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkSurfaceKHR* pSurface);

The wrong signatures of the API's can found in the link below .
https://github.com/KhronosGroup/Vulkan-Loader/blob/master/loader/wsi.c

LOADER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateAndroidSurfaceKHR(VkInstance instance, ANativeWindow *window,const VkAllocationCallbacks *pAllocator,VkSurfaceKHR *pSurface)

VKAPI_ATTR VkResult VKAPI_CALL terminator_CreateAndroidSurfaceKHR(VkInstance instance, Window window,const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface)

I guess the body of terminator_CreateAndroidSurfaceKHR() should be modified to comply with the right signature.
In addition terminator_CreateAndroidSurfaceKHR() should be declared in wsi.h

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions