Fix a lot of keyword-related issues with some PDF search impact#4
Merged
mkinsner merged 5 commits intoKhronosGroup:masterfrom Jun 12, 2019
Merged
Fix a lot of keyword-related issues with some PDF search impact#4mkinsner merged 5 commits intoKhronosGroup:masterfrom
mkinsner merged 5 commits intoKhronosGroup:masterfrom
Conversation
This makes the "_" to be searchable.
A lot of escaping of _ were actually useless and might cause some trouble in the PDF output.
The "_" are replaced by space in the PDF search otherwise... Use \codeinline as expected instead.
This fix some wrong typing in the sense of computer programming. It fixes also a lot of typesetting problems, such as PDF search due to wrong "_" rendering. The remaining \keyword is some technical debt about creating new glossary entries in the specification.
|
|
mkinsner
reviewed
Jun 11, 2019
mkinsner
approved these changes
Jun 11, 2019
mkinsner
left a comment
There was a problem hiding this comment.
This was a significant effort - thanks Ronan! I don't notice any bugs, and I've verified that I can build your branch locally. cl_command_queue_info is now found in my PDF viewer under Windows.
It seems to work with MacOS X Preview 10.1 (944.6.16.1) Safari 12.1.1 (14607.2.6.1.1) has still some problems to find all the 43 occurrences. Actually 33 are found forward and 10 found backward... I find this... awkward :-(
keryell
commented
Jun 11, 2019
Member
Author
keryell
left a comment
There was a problem hiding this comment.
I think I am done on my side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a try to fix #3
Replace most of the
\keywordby\codeinlineor\gls-like glossariesThis fix some wrong typing in the sense of computer programming.
It fixes also a lot of typesetting problems, such as PDF search due to
wrong "_" rendering.
The remaining \keyword is some technical debt about creating new
glossary entries in the specification.
Do not use
\textbffor keywords.The "_" are replaced by space in the PDF search otherwise...
Use
\codeinlineas expected instead.Remove useless
\_and fix some typesettingA lot of escaping of
_were actually useless and might cause sometrouble in the PDF output.
Use correct typesetting of
async_handlerin the glossary.This makes the "_" to be searchable.
Now there are 43 instances of
async_handlerfound.Improve
async_handlerglossary encoding for MacOS X Preview search.On the crazy part on Mac OS X:
If there are people using Mac OS X who want to open some bug reports, go for it.