Skip to content

Updates to final ray tracing extensions#4027

Closed
dgkoch wants to merge 1 commit intoKhronosGroup:masterfrom
dgkoch:khr_rt_final
Closed

Updates to final ray tracing extensions#4027
dgkoch wants to merge 1 commit intoKhronosGroup:masterfrom
dgkoch:khr_rt_final

Conversation

@dgkoch
Copy link
Copy Markdown
Contributor

@dgkoch dgkoch commented Nov 23, 2020

Updates to final spec semantics in KhronosGroup/SPIRV-Registry#86

Depends on header updates in KhronosGroup/SPIRV-Headers#182

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 23, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

This was referenced Nov 23, 2020
Merged
Closed
@dgkoch
Copy link
Copy Markdown
Contributor Author

dgkoch commented Nov 23, 2020

cc @raunraun @johnkslang @dneto0 @alan-baker

s-perron
s-perron previously approved these changes Nov 23, 2020
View reviewed changes
@s-perron
Copy link
Copy Markdown
Collaborator

s-perron commented Nov 23, 2020

Change look good to me, but before spirv-header must be merged before we can merge this change. We should also update the DEPS file once spirv-headers is merged.

There is also an issue with the CLA. @jekstrand, can you sign the CLA?

@s-perron s-perron self-requested a review November 23, 2020 14:50
@s-perron s-perron dismissed their stale review November 23, 2020 14:51

The DEPS file should be updated as well.

@dneto0
Copy link
Copy Markdown
Collaborator

dneto0 commented Nov 23, 2020

SPIRV-Headers change has been merged.

@dgkoch
Copy link
Copy Markdown
Contributor Author

dgkoch commented Nov 23, 2020

SPIRV_headers has been merged now, I'll rebase.

@dgkoch
Update to final ray tracing extensions
345cfda 
Drop Provisional from ray tracing enums
    sed -ie 's/RayQueryProvisionalKHR/RayQueryKHR/g' **/*
    sed -ie 's/RayTracingProvisionalKHR/RayTracingKHR/g' **/*
Add terminator support for SpvOpIgnoreIntersectionKHR and SpvOpTerminateRayKHR
Update deps for SPIRV-Headers
@dneto0
Copy link
Copy Markdown
Collaborator

dneto0 commented Nov 23, 2020

FYI. Glslang/shaderc parts of the smoketest are expected to fail until KhronosGroup/glslang#2466 is merged

@s-perron
Copy link
Copy Markdown
Collaborator

s-perron commented Nov 23, 2020

@dgkoch It look like the base_operand_capabilities_test are failing.

@dneto0
Copy link
Copy Markdown
Collaborator

dneto0 commented Nov 23, 2020

I might have messed things up here. I also merged KhronosGroup/SPIRV-Headers#180 to fix a capability depedendency. That my have caused some capability tests to fail. I'll see about verifying and fixing.

@dneto0 dneto0 mentioned this pull request Nov 23, 2020
Merged
@dneto0
Copy link
Copy Markdown
Collaborator

dneto0 commented Nov 23, 2020

This support was merged as part of #4028

@dneto0 dneto0 closed this Nov 23, 2020
@dgkoch dgkoch deleted the khr_rt_final branch November 23, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s-perron s-perron Awaiting requested review from s-perron

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dgkoch @CLAassistant @s-perron @dneto0