Remove single iteration loop#3532
Closed
zoddicus wants to merge 1 commit intoKhronosGroup:masterfrom
zoddicus:fixChromiumBuilds
Closed
Remove single iteration loop#3532zoddicus wants to merge 1 commit intoKhronosGroup:masterfrom zoddicus:fixChromiumBuilds
zoddicus wants to merge 1 commit intoKhronosGroup:masterfrom
zoddicus:fixChromiumBuilds
Conversation
This loop is intentionally designed to only ever execute, which is non-obvious on first glance. Changing the code to be clearer that the entire data structure isn't being iterated. This will also fix importing SPIRV-Tools into Chromium, since their style checkers are failing the build due to this iterate once construct.
Contributor
|
LGTM but it seems that #3513 will solve this issue. |
Contributor
Author
|
Superseded by #3513 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This loop is intentionally designed to only ever execute, which is non-obvious
on first glance. Changing the code to be clearer that the entire data structure
isn't being iterated.
This will also fix importing SPIRV-Tools into Chromium, since their style
checkers are failing the build due to this iterate once construct.