Skip to content

Remove asserts from GetUnderlyingType#2646

Merged
zoddicus merged 2 commits intoKhronosGroup:masterfrom
zoddicus:issue2645
May 31, 2019
Merged

Remove asserts from GetUnderlyingType#2646
zoddicus merged 2 commits intoKhronosGroup:masterfrom
zoddicus:issue2645

Conversation

@zoddicus
Copy link
Copy Markdown
Contributor

@zoddicus zoddicus commented May 30, 2019

Fixes #2463

@zoddicus zoddicus requested a review from alan-baker May 30, 2019 20:29
@zoddicus zoddicus self-assigned this May 30, 2019
alan-baker
alan-baker requested changes May 30, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@alan-baker alan-baker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests please

@zoddicus
Copy link
Copy Markdown
Contributor Author

zoddicus commented May 31, 2019

Tests please

Done

@zoddicus zoddicus requested a review from alan-baker May 31, 2019 14:50
@zoddicus zoddicus merged commit 699e167 into KhronosGroup:master May 31, 2019
@zoddicus zoddicus deleted the issue2645 branch May 31, 2019 16:04
@zoddicus zoddicus mentioned this pull request May 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alan-baker alan-baker alan-baker approved these changes

Assignees

@zoddicus zoddicus

Labels

component:validation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[spiv-val] Miscompiled SPIR-V is crashing the validator

2 participants

@zoddicus @alan-baker