linker: Add tests for various type comparisons#2613
Merged
s-perron merged 1 commit intoKhronosGroup:masterfrom May 24, 2019
Merged
linker: Add tests for various type comparisons#2613s-perron merged 1 commit intoKhronosGroup:masterfrom
s-perron merged 1 commit intoKhronosGroup:masterfrom
Conversation
This adds a number of tests that check that all types will match to identically written clones during linking, including nearly every Type and some combinations (e.g. Functions of Arrays of Floats). Intent is for use with KhronosGroup#2580, however that PR focuses on issues with TypeArray whereas these tests are (more) comprehensive and test more subtle (and possibly incorrect) cases. A number of these tests fail, many are fixed by the aforementioned PR. Some additional tests involving TypeForwardPointer are currently disabled as they cause assertion failures.
c25d1ab to
fe5a18e
Compare
Contributor
Author
|
@pierremoreau please have a look and let me know if there are any mistakes. The tests are cases where the matched types are identical (byte-for-byte, but not just equivalent where for e.g. the constant’s types differ), so they should be helpful for development on #2580 etc. |
Contributor
|
Thanks, I’ll have a look at it tomorrow. I have been re-writing the code in #2580 to have all the checking done in |
s-perron
approved these changes
May 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a number of tests that check that all types will match to identically written clones during linking, including nearly every Type and some combinations (e.g. Functions of Arrays of Floats). Intent is for use with #2580, however that PR focuses on issues with TypeArray whereas these tests are (more) comprehensive and test more subtle (and possibly incorrect) cases.
A number of these tests fail (and are disabled to pass CI checks), many are fixed by the aforementioned PR. Some additional tests involving TypeForwardPointer cause assertion failures, although the cases they describe are more rare.