reduce: fix loop to selection pass for loops with combined header/continue block#2480
Merged
paulthomson merged 2 commits intoKhronosGroup:masterfrom Mar 29, 2019
Conversation
afd
reviewed
Mar 27, 2019
Contributor
afd
left a comment
There was a problem hiding this comment.
I very much like the way you have cleaned up the code, and the fix for the issue looks good.
Regarding having both MergeBlockId and MergeBlockIdIfAny: I like it, but it occurred to me that in release mode they are functionally equivalent as assertions are disabled. I also wonder whether the comment "Returns MergeBlockIdIfAny() and asserts that it is non-zero" is guilty of parroting what the implementation of the method does. That said, I can't really think of a more useful comment as the method is very simple.
alan-baker
approved these changes
Mar 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BasicBlock::MergeBlockId()andBasicBlock::ContinueBlockId().structured_loop_to_selection_reduction_opportunity.cpp.