reduce: fix loop to selection dominance query#2477
Merged
paulthomson merged 3 commits intoKhronosGroup:masterfrom Mar 26, 2019
Merged
reduce: fix loop to selection dominance query#2477paulthomson merged 3 commits intoKhronosGroup:masterfrom
paulthomson merged 3 commits intoKhronosGroup:masterfrom
Conversation
afd
approved these changes
Mar 26, 2019
Contributor
afd
left a comment
There was a problem hiding this comment.
The change looks good. My only question is whether the project has a preference for "if (p == nullptr)" vs. "if (!p)" - I don't have an opinion on which is preferable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2457.
StructuredLoopToSelectionReductionOpportunity::FixNonDominatedIdUsesconsiders every instruction in the function being modified and tries to fix dominance by checking the dominance of all uses. Unfortunately, some of these "uses" can be OpDecorate instructions that are outside of blocks, which causes a segfault.