Convert sampled consumers to being Instructions instead of IDs#2464
Merged
zoddicus merged 3 commits intoKhronosGroup:masterfrom Mar 19, 2019
zoddicus:issue2463
Merged
Convert sampled consumers to being Instructions instead of IDs#2464zoddicus merged 3 commits intoKhronosGroup:masterfrom zoddicus:issue2463
zoddicus merged 3 commits intoKhronosGroup:masterfrom
zoddicus:issue2463
Conversation
Changing the stored value for a sampled image consumer to be the instruction instead of result ID, since not all instructions have result IDs. Using result IDs led to a potential crash when using OpReturnValue, which doesn't have a result ID. OpReturnValue is not a legal consumer, but the validator needs to look at the instruction to determine this, thus storing the pointer to the instruction, instead of trying to fetch the pointer using the instruction. Issue #1528 covers fixing the check. Fixes #2463
alan-baker
requested changes
Mar 18, 2019
Contributor
alan-baker
left a comment
There was a problem hiding this comment.
Thanks for this. Can you add a test for this that validates till the other issue is resolved so we catch any regressions here.
Contributor
Author
Done, created a reduced case of the example provided in the bug. |
alan-baker
approved these changes
Mar 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the stored value for a sampled image consumer to be the
instruction instead of result ID, since not all instructions have
result IDs. Using result IDs led to a potential crash when using
OpReturnValue, which doesn't have a result ID. OpReturnValue is not a
legal consumer, but the validator needs to look at the instruction to
determine this, thus storing the pointer to the instruction, instead
of trying to fetch the pointer using the instruction.
Issue #1528 covers fixing the check.
Fixes #2463