Skip to content

spirv-fuzz: Fact manager deduces incorrect equation facts #4008

Closed
#4009
Closed
spirv-fuzz: Fact manager deduces incorrect equation facts#4008
#4009
@Vasniktel

Description

@Vasniktel
Vasniktel
opened on Nov 2, 2020

The bug is in

SPIRV-Tools/source/fuzz/fact_manager/data_synonym_and_id_equation_facts.cpp

Lines 179 to 184 in f7da527

if (synonymous_.IsEquivalent(*equation.operands[0], *rhs_dds[1])) {
// Equation form: "a = (c - e) + c"
// We can thus infer "a = -e"
AddEquationFactRecursive(lhs_dd, SpvOpSNegate,
{equation.operands[1]});
}

If we have an equation a = (c - e) + c then a = -e is obviously false.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions