Skip to content

Can we avoid source file name collisions? #2754

@jamesdolan

Description

@jamesdolan

Small enhancement request...

For a variety of reasons, its cleaner for me to build SpirvTools as a single lib due to all the required code-gen it requires and complex internal search pathing, but msbuild does not maintain directory structure of its intermediates directory, this results in vs2019 emitting the following warnings (and subsequent missing symbol errors)....

warning MSB8027: Two or more files with the name of basic_block.cpp will produce outputs to the same location. This can lead to an incorrect build result.  The files involved are SPIRV-Tools\source\opt\basic_block.cpp, SPIRV-Tools\source\val\basic_block.cpp.
warning MSB8027: Two or more files with the name of function.cpp will produce outputs to the same location. This can lead to an incorrect build result.  The files involved are SPIRV-Tools\source\opt\function.cpp, SPIRV-Tools\source\val\function.cpp.
warning MSB8027: Two or more files with the name of instruction.cpp will produce outputs to the same location. This can lead to an incorrect build result.  The files involved are SPIRV-Tools\source\opt\instruction.cpp, SPIRV-Tools\source\val\instruction.cpp.

...IMHO it would seem cleaner anyways to not have a bunch of source files with identical names kicking around in the same project.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions