Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: KhronosGroup/SPIRV-Tools
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f701237f2d88
Choose a base ref
...
head repository: KhronosGroup/SPIRV-Tools
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bc62722b80a6
Choose a head ref
  • 8 commits
  • 31 files changed
  • 5 contributors

Commits on Aug 14, 2019

  1. Replace OpKill With function call. (#2790)

    We are no able to inline OpKill instructions into a continue construct.
    See #2433.  However, we have to be able to inline to correctly do
    legalization.  This commit creates a pass that will wrap OpKill
    instructions into a function of its own.  That way we are able to inline
    the rest of the code.
    
    The follow up to this will be to not inline any function that contains
    an OpKill.
    
    Fixes #2726
    s-perron authored Aug 14, 2019
    Configuration menu
    Copy the full SHA
    60043ed View commit details
    Browse the repository at this point in the history
  2. Fix validation of constant matrices (#2794)

    Fixes #2793
    
    * Don't special case matrix validation compared to other composites
      * just check the constituents are constants or undefs
      * later checking validates the column type
      * new test
    alan-baker authored Aug 14, 2019
    Configuration menu
    Copy the full SHA
    bbd8046 View commit details
    Browse the repository at this point in the history
  3. Change the way to include header (#2795)

    `#include <source/util/string_utils.h>` works only when we specify
    `include_directories(${CMAKE_CURRENT_SOURCE_DIR}/)` in
    cmake. It is hard to set the source directory as a include path
    in some build systems e.g., bazel. Using the relative path easily
    solves this issue. This commit uses
    `#include "source/util/string_utils.h"` instead of
    `#include <source/util/string_utils.h>`.
    jaebaek authored Aug 14, 2019
    Configuration menu
    Copy the full SHA
    ff872dc View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2019

  1. Use ascii code based characters (#2796)

    My local python reports that CHANGES uses a non-ascii code
    character and fail in running utils/update_build_version.py.
    jaebaek authored and dnovillo committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    dac9210 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7b4e5bd View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2019

  1. Configuration menu
    Copy the full SHA
    0640725 View commit details
    Browse the repository at this point in the history
  2. More handle overflow in sroa (#2800)

    If we run out of ids when creating a new variable, sroa does not recognize
    the error, and continues doing work.  This leads to segmentation faults.
    
    Fixes https://crbug/969655
    s-perron authored Aug 16, 2019
    Configuration menu
    Copy the full SHA
    9cd0727 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2019

  1. Handle overflow in wrap-opkill (#2801)

    Fixes https://crbug/994203
    s-perron authored Aug 18, 2019
    Configuration menu
    Copy the full SHA
    bc62722 View commit details
    Browse the repository at this point in the history
Loading