Skip to content

sdk: Common: Add stdint.h include to platform_utils.hpp for GCC 13+#406

Merged
rpavlik merged 1 commit intoKhronosGroup:mainfrom
akien-mga:patch-1
Jun 7, 2023
Merged

sdk: Common: Add stdint.h include to platform_utils.hpp for GCC 13+#406
rpavlik merged 1 commit intoKhronosGroup:mainfrom
akien-mga:patch-1

Conversation

@akien-mga
Copy link
Copy Markdown
Contributor

GCC 13 seems to have changed some implicit includes in standard headers, and now stdint.h needs to be included explicitly to use uint16_t in this file.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 7, 2023

CLA assistant check
All committers have signed the CLA.

@rpavlik
Copy link
Copy Markdown
Contributor

rpavlik commented Jun 7, 2023

Can you please add a changelog fragment in changes/sdk per the readme in that directory? Would be named pr.406.gh.OpenXR-SDK-Source.md

@rpavlik rpavlik added the needs changelog fragment Someone, preferably the submitter, needs to add a changelog fragment describing this. label Jun 7, 2023
@akien-mga
Copy link
Copy Markdown
Contributor Author

Done, let me know if that's satisfactory.

GCC 13 seems to have changed some implicit includes in standard headers, and
now `stdint.h` needs to be included explicitly to use `uint16_t` in this file.
@akien-mga akien-mga changed the title Add stdint.h include to platform_utils.hpp for GCC 13+ sdk: Common: Add stdint.h include to platform_utils.hpp for GCC 13+ Jun 7, 2023
Copy link
Copy Markdown
Contributor

@rpavlik rpavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@rpavlik rpavlik merged commit f122f9f into KhronosGroup:main Jun 7, 2023
@akien-mga akien-mga deleted the patch-1 branch June 8, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs changelog fragment Someone, preferably the submitter, needs to add a changelog fragment describing this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants