Remove text relaxing core semaphore requirement for external semaphores#976
Merged
Remove text relaxing core semaphore requirement for external semaphores#976
Conversation
cl_khr_external_semaphore requires cl_khr_semaphore and cl_khr_semaphore requires support for base semaphores. However, cl_khr_external_semaphore allows relaxing core cl_khr_semaphore requirement to support base semaphores if importing external semaphores is supported. Clean up the text related to above and make it mandatory to support core semaphores to honor dependency of cl_khr_semaphore. Fixes #944
|
Looks good |
Contributor
|
Merging as discussed in the October 3rd memory subgroup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cl_khr_external_semaphore requires cl_khr_semaphore and cl_khr_semaphore requires support for base semaphores. However, cl_khr_external_semaphore allows relaxing core cl_khr_semaphore requirement to support base semaphores if importing external semaphores is supported.
Clean up the text related to above and make it mandatory to support core semaphores to honor dependency of
cl_khr_semaphore.
Fixes #944