add a TYPE suffix to all asciidoctor type attributes#444
Merged
alycm merged 1 commit intoKhronosGroup:masterfrom Sep 16, 2020
Merged
add a TYPE suffix to all asciidoctor type attributes#444alycm merged 1 commit intoKhronosGroup:masterfrom
alycm merged 1 commit intoKhronosGroup:masterfrom
Conversation
Because asciidoctor attributes are not currently case-sensitive, the TYPE suffix is needed to disambiguate between an API type and an enum with the same name.
Contributor
Author
|
FWIW, I found another case that will be fixed by this PR: Without this change there is an ambiguity between the |
alycm
approved these changes
Sep 16, 2020
Contributor
alycm
left a comment
There was a problem hiding this comment.
LGTM. I hadn't realized that the actual wrong text was ending up in the rendered output.
The changes are all very procedural, this doesn't need to wait for extra reviews, I'll merge immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #443.
Because asciidoctor attributes are not currently case-sensitive, the TYPE suffix is needed to disambiguate between an API type and an enum with the same name.