Test mutable command-buffer deferred kernel arguments#2538
Merged
bashbaug merged 2 commits intoKhronosGroup:mainfrom Nov 27, 2025
Merged
Test mutable command-buffer deferred kernel arguments#2538bashbaug merged 2 commits intoKhronosGroup:mainfrom
bashbaug merged 2 commits intoKhronosGroup:mainfrom
Conversation
Tests the scenario outlined in KhronosGroup#2520 (comment) to verify the functionality added in OpenCL-Docs PR KhronosGroup/OpenCL-Docs#1382. Note that this bumps the required cl_khr_command_buffer_mutable_dispatch minor version by 2 because KhronosGroup#2477 is not yet merged which test the intermediate version. This also assumes the proposed OpenCL-Docs change in KhronosGroup/OpenCL-Docs#1471 is merged, as the PR does a negative test for command-buffer enqueue while the command-buffer is in the finalized state. Closes KhronosGroup#2520
dc63df8 to
a303bef
Compare
bashbaug
previously approved these changes
Nov 13, 2025
Contributor
bashbaug
left a comment
There was a problem hiding this comment.
It's going to be challenging to support the new FINALIZED state with the command buffer emulation layer, but these tests appear to be correct.
...hr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_defer_arguments.cpp
Show resolved
Hide resolved
…nd_buffer_mutable_dispatch/mutable_command_defer_arguments.cpp Co-authored-by: Ben Ashbaugh <ben.ashbaugh@intel.com>
bashbaug
approved these changes
Nov 14, 2025
Contributor
|
Merging as discussed over email. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests the scenario outlined in #2520 (comment) to verify the functionality added in OpenCL-Docs PR KhronosGroup/OpenCL-Docs#1382.
Closes #2520