Merged
Conversation
Member
|
Looks like the |
k4b7
reviewed
Nov 24, 2017
| // “\nonscript\mskip-\medmuskip\mkern5mu” | ||
| // “\nonscript\mskip-\medmuskip\mkern5mu”, where \medmuskip is | ||
| // 4mu plus 2mu minus 1mu, translates to 1mu space in | ||
| // display/textstyle and 5mu space in script/scriptscriptstyle. |
Member
There was a problem hiding this comment.
Took me a bit to grok what's going on, but it makes sense.
Member
Author
|
Hmm, seems there's more investigation to do. Here's the diff between old and new screenshots (green is new):
More clear is to look at the texdiff. Before this PR is near-perfect in the top left:
After this PR is worse:
Not sure why. Maybe adding kerns is not equivalent... |
Member
Author
|
Turns out I just failed to properly add the muspace CSS rule. (Alternatively, we could add 1mu as a manual style value instead of using a CSS rule.) I believe the Mod screenshots are now unaffected; this will be confirmed once Travis finishes. |
edemaine
added a commit
to edemaine/KaTeX
that referenced
this pull request
Mar 3, 2018
Fix KaTeX#984 The screenshot test is still somewhat defective, showing a space before the "post" text (a period). This seems limited to the screenshotter, however, as it works fine in the tester via http://localhost:7936/?text=%5Cfbox%7B%5C%241%2C%5C!000%2C%5C!000%7D%5CKaTeX&display=0&after=.
edemaine
added a commit
to edemaine/KaTeX
that referenced
this pull request
Mar 6, 2018
Fix KaTeX#984 The screenshot test is still somewhat defective, showing a space before the "post" text (a period). This seems limited to the screenshotter, however, as it works fine in the tester via http://localhost:7936/?text=%5Cfbox%7B%5C%241%2C%5C!000%2C%5C!000%7D%5CKaTeX&display=0&after=.
k4b7
pushed a commit
that referenced
this pull request
Mar 9, 2018
* Work around negative space bug in Chrome Fix #984 The screenshot test is still somewhat defective, showing a space before the "post" text (a period). This seems limited to the screenshotter, however, as it works fine in the tester via http://localhost:7936/?text=%5Cfbox%7B%5C%241%2C%5C!000%2C%5C!000%7D%5CKaTeX&display=0&after=. * Update screenshots * Switch to inherited `width: min-content`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround for #836 for the command case of using \bmod, without changing any spacing (and making the code and generated output slightly more efficient). In particular, fixes #982.