Skip to content

Change \undertilde to \utilde#948

Merged
k4b7 merged 4 commits intoKaTeX:masterfrom
ronkok:utilde
Nov 24, 2017
Merged

Change \undertilde to \utilde#948
k4b7 merged 4 commits intoKaTeX:masterfrom
ronkok:utilde

Conversation

@ronkok
Copy link
Collaborator

@ronkok ronkok commented Oct 24, 2017

In PR #670, I made an error. The function that should have been \utilde I named instead \undertilde.

There is an \undertilde from the wsuipa package, but it is a text-mode non-stretchy function. The proper command name is \utilde, a math-mode, stretchy function from packge undertilde.

This PR fixes my error.

In PR #670, I made an error. The function that should have been `\utilde` I named instead `\undertilde`.

There is an `\undertilde` from the `wsuipa` package, but it is a text-mode non-stretchy function. The proper command name is `\utilde`, a math-mode, stretchy function from packge `undertilde`.

This PR fixes my error.
@k4b7
Copy link
Member

k4b7 commented Oct 24, 2017

Let's do a version bump to 0.11.x 0.10.x for this even though it's a bug fix so that people if anyone was using \undertilde it'll be less likely they'll be caught off guard by the change.

Copy link
Member

@edemaine edemaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @kevinbarabash Should we merge this into master now, or wait to non-alpha-release 0.9.0? Or, given that we're already changing the number to 0.9.0, maybe it's OK to include as part of 0.9.0?

@k4b7
Copy link
Member

k4b7 commented Oct 25, 2017

@edemaine good question. I was thinking of jumping to 0.10.0-alpha... we could also do 0.9.0 and just call out this breaking change and the one that was in 0.9.0-alpha.

@edemaine
Copy link
Member

edemaine commented Nov 21, 2017

@kevinbarabash Any objection to merging this to master? (now 1 month later) I don't want to overstep if you're about to release. We could do another 0.9.0 alpha/beta... (In any case, I think releasing is important to get the array bug fix out.)

Personally, I think changing this in 0.9.0 is fine.

@k4b7 k4b7 merged commit 75af19c into KaTeX:master Nov 24, 2017
@ronkok ronkok deleted the utilde branch November 24, 2017 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants