Enable spacing functions in text mode#1139
Merged
k4b7 merged 4 commits intoKaTeX:masterfrom Feb 4, 2018
ronkok:fixLaps
Merged
Conversation
Spacing functions such as `\;` or `\quad` should be accepted in either math mode or text mode
k4b7
requested changes
Feb 3, 2018
Member
k4b7
left a comment
There was a problem hiding this comment.
Thanks for fixing this. Can you add some unit tests that check that things like \llap{\,} and \rlap{\;} parse?
Collaborator
Author
|
Done. |
k4b7
approved these changes
Feb 4, 2018
| }); | ||
| }); | ||
|
|
||
| describe("An lap parser", function() { |
Member
There was a problem hiding this comment.
I didn't realize we didn't have any unit test for lap. Thanks for adding these.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spacing functions such as
\;or\quadshould be accepted in either math mode or text mode. This PR will also fix a bug in\llapand\rlapand enable them to accept spacing functions.