Skip to content

add \i and \j for text mode#1029

Merged
edemaine merged 1 commit intomasterfrom
dotless_text_i_j
Dec 22, 2017
Merged

add \i and \j for text mode#1029
edemaine merged 1 commit intomasterfrom
dotless_text_i_j

Conversation

@k4b7
Copy link
Member

@k4b7 k4b7 commented Dec 22, 2017

screen shot 2017-12-22 at 11 31 00 am

@k4b7 k4b7 requested a review from edemaine December 22, 2017 18:35
Copy link
Member

@ry-randall ry-randall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a test here?

Copy link
Member

@edemaine edemaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this as-is. I guess I'll add Unicode support for these too in #992 (like I did for \imath and \jmath).

@k4b7
Copy link
Member Author

k4b7 commented Dec 22, 2017

@rrandallcainc I added a test to verify that \\text{\\i\\j} parses. A screenshot test is probably overkill for this as there a lots of symbols we don't have screenshot tests for.

Copy link
Member

@ry-randall ry-randall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edemaine edemaine merged commit 2b2cf73 into master Dec 22, 2017
@k4b7 k4b7 deleted the dotless_text_i_j branch December 29, 2017 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants